MX linux support #4770
MX linux support #4770
Conversation
MX Linux is based on Debian stable, so it is trivial to add support for it. During testing I noticed that the dpkg-query check in apt_get_install_pkgs always assumes the packages are installed even when they aren't. This is probably a subtle behavior change between the /bin/sh versions in MX and Debian testing (I am not entirely sure though). This check was introduced in commit b46e5a7 a few days back, reverting that to the previous version works fine in MX and Debian stretch. Please let me know if this is a problem, I'll try to find an alternative fix.
etc/scripts/get-stack.sh
Outdated
| @@ -609,7 +609,7 @@ try_install_pkgs() { | |||
|
|
|||
| # Install packages using apt-get | |||
| apt_get_install_pkgs() { | |||
| if ! dpkg-query -W "$@"|grep -v '^\S\+\s\+.\+$' > /dev/null; then | |||
| if dpkg-query -W "$@" > /dev/null; then | |||
There was a problem hiding this comment.
Any particular reason you changed this? I believe the reason for the grep was to make it detect if only some of the required packages are missing. That said, it could be more intelligent by only trying to install the actually missing dependencies (rather than all of them, even if only some are missing).
There was a problem hiding this comment.
See my comment above. This is somehow broken in the version of /bin/sh that MX uses (which is based on Debian stable). I can try to figure out a better way to handle it.
There was a problem hiding this comment.
Ok, sorry I didn't read the description well enough. I'm OK with the revert, but how about adding a comment with what you reverted and why (and a link to this discussion) so that if we change it again we won't accidentally break MX.
There was a problem hiding this comment.
I added a comment and verified this in both Debian and MX.
|
Looks good, thanks! |
Please include the following checklist in your PR:
Tested this by running the script against MX Linux 18.2 and Debian Stretch.
During testing I noticed that the dpkg-query check in apt_get_install_pkgs always assumes
that the packages are installed even when they aren't. This happens only on MX and not on
Debian and is probably a subtle behavior change between the /bin/sh versions in MX and Debian testing (I am not entirely sure though). This check was introduced in commit b46e5a7 a few days
back, reverting that to the previous version works fine in MX and Debian stretch. Please let me know if this is a problem, I'll try to find an alternative fix.